Skip to content

Conversation

@RS-labhub
Copy link

@RS-labhub RS-labhub commented Oct 22, 2023

Open in Gitpod know more

Describe your change:

Added maximum index code for array dsa

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Added maximum index code for array dsa
@RS-labhub
Copy link
Author

@raklaptudirm @appgurueu please review this

@appgurueu
Copy link
Collaborator

appgurueu commented Oct 22, 2023

Sorry, but please take a look at our contribution guidelines; we expect JavaScript, not HTML containing JS, and a proper separation between implementation and tests.

I'm afraid this "algorithm" also wouldn't be a good fit; it pretty much boils down to trivial usage of reduce / a simple for loop.

@appgurueu appgurueu closed this Oct 22, 2023
@RS-labhub
Copy link
Author

Sorry, but please take a look at our contribution guidelines; we expect JavaScript, not HTML containing JS, and a proper separation between implementation and tests.

I'm afraid this "algorithm" also wouldn't be a good fit; it pretty much boils down to trivial usage of reduce / a simple for loop.

Will look for some other good files. Thank you for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants