Skip to content

feat: add row echelon matrix algorithm #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 11, 2023
Merged

feat: add row echelon matrix algorithm #1454

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f98b585
feat: add row echelon matrix algorithm
piyushk77 Oct 6, 2023
d9e7ffa
test: add self-tests for row echelon algorithm
piyushk77 Oct 6, 2023
5a7fb87
fix: replace rounding with float tolerance
piyushk77 Oct 10, 2023
64d1afc
chore: use correct style
piyushk77 Oct 10, 2023
2200c0e
fix: use error tolerance and segregate testcases
piyushk77 Oct 10, 2023
39fed98
chore: add necessary explaining comments
piyushk77 Oct 10, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use error tolerance and segregate testcases
  • Loading branch information
@piyushk77
piyushk77 committed Oct 10, 2023
commit 2200c0e74e1a02bec53c5e8605f6e27a3d64d15e
37 changes: 21 additions & 16 deletions Maths/test/RowEchelon.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { rowEchelon } from '../RowEchelon'
describe('Determinant', () => {
const testCases = [
const tolerance = 0.000001
test.each([
[
[
[8, 1, 3, 5],
Expand Down Expand Up @@ -45,14 +46,6 @@ describe('Determinant', () => {
[0, 0, 0]
]
],
[
[
[8, 1, 3, 5],
[4, 6, 8, 2, 7],
[3, 5, 6, 8]
],
'Input is not a valid 2D matrix.'
],
[
[
[0, 7, 8, 1, 3, 5],
Expand All @@ -73,12 +66,24 @@ describe('Determinant', () => {
[0, 0, 0, 0, 0, 0]
]
]
]

test.each(testCases)(
'Should return the matrix in row echelon form.',
(matrix, expected) => {
expect(rowEchelon(matrix)).toEqual(expected)
])('Should return the matrix in row echelon form.', (matrix, expected) => {
for (let i = 0; i < matrix.length; i++) {
for (let j = 0; j < matrix[i].length; j++) {
expect(rowEchelon(matrix)[i][j]).toBeCloseTo(expected[i][j], tolerance)
}
}
)
})

test.each([
[
[
[8, 1, 3, 5],
[4, 6, 8, 2, 7],
[3, 5, 6, 8]
],
'Input is not a valid 2D matrix.'
]
])('Should return the error message.', (matrix, expected) => {
expect(() => rowEchelon(matrix)).toThrowError(expected)
})
})