Skip to content

Conversation

@Rimkomatic
Copy link

@Rimkomatic Rimkomatic commented Oct 5, 2023

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
zero-to-mastery-bot bot and others added 30 commits September 30, 2023 14:53
…amoldovan10 Roxanamoldovan10 roxanamoldovan10
added my name to contributor list
added my name to contributor list
zero-to-mastery-bot bot and others added 26 commits October 4, 2023 10:33
added my github name and profile like
added my name to contributor list
Add MathDevWeb to CONTRIBUTORS.md
@Rimkomatic
Copy link
Author

I have made some changes in the DepthFirstSearchIterative.js in Graph section .
I modified the code to immediately add the current node to the visited Set as soon as it's pushed onto the stack. This change reduces the number of times I check visited.has(neighbour) and improves efficiency.
It reduces the runtime of the algorithm which was 6.2ms on avg previously to 5.45 avg on my current environment.

@Rimkomatic Rimkomatic closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment