Divisors.js

[ZainabMalik5]

I have added a file for computing all unique divisors of a number in javascript in Maths folder. Please merge my PR.

[gaurovgiri]

The algorithm implementation looks good to me. However, there are few suggestions I would like to provide:

1. The function name is printDivisors(), but it doesn't prints anything, just returns a list of divisors. I suggest to change it to something like getDivisors().
2. Change variable name into something meaningful .
3. Also add documentations comment.

[ZainabMalik5]

I have made the necessary changes and sent you a pull request. Please merge it.

…

On Thu, Oct 5, 2023 at 1:43 PM Gaurav Giri ***@***.***> wrote: ***@***.**** requested changes on this pull request. The algorithm implementation looks good to me. However, there are few suggestions I would like to provide: 1. The function name is printDivisors(), but it doesn't prints anything, just returns a list of divisors. I suggest to change it to something like getDivisors(). 2. Change variable name into something meaningful . 3. Also add documentations comment. — Reply to this email directly, view it on GitHub <#1435 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWWATJMLHEVSVWCTYGMGHFLX5ZT3NAVCNFSM6AAAAAA5TCI7SGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJZGE3TQNBTHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ZainabMalik5]

Please merge PR #1435 if it's fine.

[gaurovgiri]

Great Work! Keep it up!

[appgurueu]

Missing tests. @return{Vector} should be @return{[]Integer} (Integer is treated as an undefined custom type; we could use number, but that doesn't convey the same information. Ideally consider @typedefing Integer).

I'm also not sure how useful this algorithm is given that we already have prime factorization. (This gives you all divisors of a number, but I think that is almost always less useful than prime factorization.)

[ZainabMalik5]

I have made the necessary changes in Divisors.js. Please review it.

[appgurueu]

This example is broken

[appgurueu]

I have made the necessary changes in Divisors.js. Please review it.

It's still missing tests.