Skip to content

Test running overhaul, switch to Prettier & reformat everything #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 3, 2023
Merged

Test running overhaul, switch to Prettier & reformat everything #1407

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cf38921
chore: Switch to Node 20 + Vitest
defaude Oct 1, 2023
2f58f98
chore: migrate to vitest mock functions
defaude Oct 1, 2023
cc35e55
chore: code style (switch to prettier)
defaude Oct 1, 2023
5ea795f
test: re-enable long-running test
defaude Oct 1, 2023
2fe0ba4
chore: code style
defaude Oct 2, 2023
f04c255
chore: fix failing tests
defaude Oct 2, 2023
1942cc2
Updated Documentation in README.md
Oct 2, 2023
ed96e23
Update contribution guidelines to state usage of Prettier
appgurueu Oct 2, 2023
60b4cff
fix: set prettier printWidth back to 80
defaude Oct 3, 2023
592cec4
chore: apply updated code style automatically
defaude Oct 3, 2023
3ac2a8f
fix: set prettier line endings to lf again
defaude Oct 3, 2023
f1d1c78
chore: apply updated code style automatically
defaude Oct 3, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: code style
  • Loading branch information
@defaude
defaude committed Oct 2, 2023
commit 2fe0ba49be10d79628d8ccdffe2d88d1455aa3ad
4 changes: 1 addition & 3 deletions Conversions/LengthConversion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,4 @@ const lengthConversion = (length, fromUnit, toUnit) => {
return convertedLength
}

export {
lengthConversion
}
export { lengthConversion }
73 changes: 32 additions & 41 deletions Conversions/test/LengthConversion.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,52 +2,43 @@ import { lengthConversion } from '../LengthConversion.js'

describe('LengthConversion', () => {
it.each`
length | fromUnit | toUnit | expected
${10} | ${'km'} | ${'m'} | ${10000}
${100} | ${'m'} | ${'km'} | ${0.1}
${5} | ${'cm'} | ${'mm'} | ${50}
${12} | ${'ft'} | ${'inch'}| ${144.00000000000003}
`(
'converts $length $fromUnit to $toUnit',
({ length, fromUnit, toUnit, expected }) => {
try {
const result = lengthConversion(length, fromUnit, toUnit)
expect(result).toBe(expected)
} catch (error) {
expect(error).toBeUndefined()
}
length | fromUnit | toUnit | expected
${10} | ${'km'} | ${'m'} | ${10000}
${100} | ${'m'} | ${'km'} | ${0.1}
${5} | ${'cm'} | ${'mm'} | ${50}
${12} | ${'ft'} | ${'inch'} | ${144.00000000000003}
`('converts $length $fromUnit to $toUnit', ({ length, fromUnit, toUnit, expected }) => {
try {
const result = lengthConversion(length, fromUnit, toUnit)
expect(result).toBe(expected)
} catch (error) {
expect(error).toBeUndefined()
}
)
})

it.each`
length | fromUnit | toUnit | expected
${10} | ${'m'} | ${'km'} | ${0.01}
${1000}| ${'mm'} | ${'cm'} | ${100}
${1} | ${'inch'}| ${'ft'} | ${0.08333333333}
`(
'converts $length $fromUnit to $toUnit (vice versa)',
({ length, fromUnit, toUnit, expected }) => {
try {
const result = lengthConversion(length, fromUnit, toUnit)
expect(result).toBeCloseTo(expected, 10) // Close comparison due to floating-point precision
} catch (error) {
expect(error).toBeUndefined()
}
length | fromUnit | toUnit | expected
${10} | ${'m'} | ${'km'} | ${0.01}
${1000} | ${'mm'} | ${'cm'} | ${100}
${1} | ${'inch'} | ${'ft'} | ${0.08333333333}
`('converts $length $fromUnit to $toUnit (vice versa)', ({ length, fromUnit, toUnit, expected }) => {
try {
const result = lengthConversion(length, fromUnit, toUnit)
expect(result).toBeCloseTo(expected, 10) // Close comparison due to floating-point precision
} catch (error) {
expect(error).toBeUndefined()
}
)
})

it.each`
length | fromUnit | toUnit | expectedError
${10} | ${'km'} | ${'invalid'} | ${'Invalid units'}
${5} | ${'invalid'} | ${'m'} | ${'Invalid units'}
`(
'returns error message for invalid units: $fromUnit to $toUnit',
({ length, fromUnit, toUnit, expectedError }) => {
try {
lengthConversion(length, fromUnit, toUnit)
} catch (error) {
expect(error.message).toBe(expectedError)
}
length | fromUnit | toUnit | expectedError
${10} | ${'km'} | ${'invalid'} | ${'Invalid units'}
${5} | ${'invalid'} | ${'m'} | ${'Invalid units'}
`('returns error message for invalid units: $fromUnit to $toUnit', ({ length, fromUnit, toUnit, expectedError }) => {
try {
lengthConversion(length, fromUnit, toUnit)
} catch (error) {
expect(error.message).toBe(expectedError)
}
)
})
})
5 changes: 1 addition & 4 deletions Maths/QuadraticRoots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@ const quadraticRoots = (a, b, c) => {
} else {
// Two real roots
const sqrtDiscriminant = Math.sqrt(discriminant)
return [
(-b + sqrtDiscriminant) / (2 * a),
(-b - sqrtDiscriminant) / (2 * a)
]
return [(-b + sqrtDiscriminant) / (2 * a), (-b - sqrtDiscriminant) / (2 * a)]
}
}

Expand Down
16 changes: 8 additions & 8 deletions String/ReverseString.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ function ReverseStringIterative(string) {

/**
*
* @author dev-madhurendra
* Reverses a number by converting it to a string.
*
* @param {string} str - The number to reverse.
* @returns {string} The reversed number.
*
* @example
* const reversed = reverseString("hello"); // Returns olleh
* @author dev-madhurendra
* Reverses a number by converting it to a string.
*
* @param {string} str - The number to reverse.
* @returns {string} The reversed number.
*
* @example
* const reversed = reverseString("hello"); // Returns olleh
*/

const ReverseStringIterativeInplace = (str) => [...str].reverse().join('')
Expand Down