added mergesortV2 #1304
Closed
added mergesortV2 #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
appgurueu requested changes Mar 1, 2023
There was a problem hiding this comment.
I'm afraid we have to reject this for multiple reasons:
- It's a duplicate. We already have MergeSort.
- If it was better than the current implementation, the current implementation should be replaced; this is however much worse
- It is implemented improperly (highly inefficiently): Merge should not be sorting the two halves using selectionsort
- It does not follow our coding style / conventions; code is duplicated
- It does not have proper JSDoc comments
- It is completely untested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added a sorting algorithm(merge sort)...