Skip to content

algorithm: ZFunction #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2022
Merged

algorithm: ZFunction #1239

merged 4 commits into from
Oct 31, 2022

Conversation

@Adrito-M
Copy link
Contributor

@Adrito-M Adrito-M commented Oct 28, 2022 •
edited by gitpod-io bot
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@TheAlgorithms TheAlgorithms deleted a comment from Adrito-M Oct 29, 2022
@appgurueu
Copy link
Collaborator

You don't need to ping us. Our review is automatically requested as we are code owners.
appgurueu
appgurueu reviewed Oct 29, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 29, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 29, 2022
View reviewed changes
appgurueu
appgurueu requested changes Oct 29, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add comments in the code.
@Adrito-M Adrito-M requested a review from appgurueu October 29, 2022 20:03
appgurueu
appgurueu reviewed Oct 30, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 30, 2022
View reviewed changes
@Adrito-M Adrito-M requested a review from appgurueu October 30, 2022 16:17
@raklaptudirm raklaptudirm merged commit 7fb1215 into TheAlgorithms:master Oct 31, 2022
@Adrito-M Adrito-M deleted the ZFunction branch October 31, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Adrito-M @appgurueu @raklaptudirm