Skip to content

algorithm: kosaraju #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2022
Merged

algorithm: kosaraju #1215

merged 5 commits into from
Oct 20, 2022

Conversation

@Adrito-M
Copy link
Contributor

@Adrito-M Adrito-M commented Oct 19, 2022 •
edited by gitpod-io bot
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Adrito-M
Copy link
Contributor Author

Adrito-M commented Oct 19, 2022

@raklaptudirm @appgurueu This PR solves issue #1214
@Adrito-M Adrito-M mentioned this pull request Oct 19, 2022
Closed
appgurueu
appgurueu reviewed Oct 19, 2022
View reviewed changes
@Adrito-M
Copy link
Contributor Author

Adrito-M commented Oct 19, 2022

Please Take A Look
@Adrito-M Adrito-M requested a review from appgurueu October 19, 2022 16:36
appgurueu
appgurueu previously approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider hiding the class as an implementation detail by only exporting a function kosaraju(graph) (which uses the class).
@Adrito-M Adrito-M requested a review from appgurueu October 19, 2022 21:15
@Adrito-M
Copy link
Contributor Author

Adrito-M commented Oct 20, 2022

@raklaptudirm please take a look
@raklaptudirm raklaptudirm changed the title kosaraju and test added algorithm: kosaraju Oct 20, 2022
@raklaptudirm raklaptudirm merged commit ce9e294 into TheAlgorithms:master Oct 20, 2022
@Adrito-M Adrito-M deleted the Kosaraju branch October 20, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Adrito-M @appgurueu @raklaptudirm