Skip to content

algorithm: sieve #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2022
Merged

algorithm: sieve #1205

merged 2 commits into from
Oct 20, 2022

Conversation

@ddaniel27
Copy link
Contributor

@ddaniel27 ddaniel27 commented Oct 18, 2022 •
edited by gitpod-io bot
Loading

This algorithm is a distinct implementation of the current sieve in the repo because this returns an array of integers that only contain prime numbers.

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@ddaniel27
[CREATE] Add another sieve algorithm
968ac86 
This algorithm is a distinct implementation of the current sieve in the repo because this returns an array of integers that only contain prime numbers.
appgurueu
appgurueu reviewed Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add tests.
@ddaniel27
Copy link
Contributor Author

ddaniel27 commented Oct 18, 2022

Tests added
@raklaptudirm raklaptudirm changed the title [CREATE] Add another sieve algorithm algorithm: sieve Oct 20, 2022
@raklaptudirm raklaptudirm merged commit 0084acf into TheAlgorithms:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@ddaniel27 @appgurueu @raklaptudirm