Skip to content

tests: Project Euler Problem 2 #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 16, 2022
Merged

tests: Project Euler Problem 2 #1200

merged 12 commits into from
Oct 16, 2022

Conversation

@pomkarnath98
Copy link
Member

@pomkarnath98 pomkarnath98 commented Oct 16, 2022

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
appgurueu
appgurueu reviewed Oct 16, 2022
View reviewed changes
Project-Euler/Problem002.js Outdated
// theoretically it should take O(1) constant amount of time as long
// arithmetic calculations are considered to be in constant amount of time
export const EvenFibonacci = (limit) => {
if (limit < 1) throw new Error('Fibonacci sequence limit can\'t be lesser than 1')
Copy link
Collaborator

@appgurueu appgurueu Oct 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less than*
appgurueu
appgurueu previously approved these changes Oct 16, 2022
View reviewed changes
@raklaptudirm raklaptudirm changed the title Project Euler 002 testcases tests: Project Euler Problem 2 Oct 16, 2022
@raklaptudirm raklaptudirm merged commit 2a62eab into TheAlgorithms:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@pomkarnath98 @appgurueu @raklaptudirm @omkarnathparida