Skip to content

algorithm: find the middle of linked-list #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 10, 2022
Merged

algorithm: find the middle of linked-list #1096

merged 5 commits into from
Sep 10, 2022

Conversation

@10kartik
Copy link
Contributor

@10kartik 10kartik commented Sep 8, 2022 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
nuhmanpk
nuhmanpk previously approved these changes Sep 8, 2022
View reviewed changes
appgurueu
appgurueu requested changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the form we expect algorithms to be in. Please:

  • Add comments;
  • Make this a re-usable and exported function;
  • Add tests
@10kartik 10kartik requested review from appgurueu and nuhmanpk and removed request for appgurueu and nuhmanpk September 9, 2022 06:50
@10kartik
Copy link
Contributor Author

10kartik commented Sep 9, 2022

Hello @appgurueu, I hope the algorithm is now as expected:

  • Reusable and exported function solution
  • Added tests
  • Changed comments

Please review and suggest changes, if any.
Thanks!
appgurueu
appgurueu requested changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need for a class here; this should be a single function or a method of a linked list class (if there is a suitable one).
appgurueu
appgurueu reviewed Sep 9, 2022
View reviewed changes
@10kartik 10kartik requested a review from appgurueu September 9, 2022 08:30
@10kartik
Copy link
Contributor Author

10kartik commented Sep 9, 2022

Hey @appgurueu, Adding a method in the existing LinkedList class made more sense.
Please review and suggest changes, if any.
Thanks!
appgurueu
appgurueu reviewed Sep 9, 2022
View reviewed changes
appgurueu
appgurueu reviewed Sep 9, 2022
View reviewed changes
appgurueu
appgurueu reviewed Sep 9, 2022
View reviewed changes
@appgurueu appgurueu added the algorithm Adds or improves an algorithm label Sep 9, 2022
@raklaptudirm raklaptudirm changed the title Added Middle of linked-list implementation. algorithm: find the middle of linked-list Sep 10, 2022
@raklaptudirm raklaptudirm merged commit 6ad2467 into TheAlgorithms:master Sep 10, 2022
@10kartik 10kartik deleted the develop branch September 14, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

algorithm Adds or improves an algorithm

4 participants

@10kartik @appgurueu @nuhmanpk @raklaptudirm