Skip to content

fix: factorial function #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2022
Merged

fix: factorial function #1093

merged 3 commits into from
Sep 7, 2022

Conversation

@itsAkshayDubey
Copy link
Contributor

@itsAkshayDubey itsAkshayDubey commented Sep 6, 2022

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Issue #1092

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@appgurueu appgurueu added fix Fixes a bug code quality Code quality improvement and removed fix Fixes a bug labels Sep 6, 2022
@raklaptudirm raklaptudirm changed the title Fix calc factorial function fix: factorial function Sep 7, 2022
@raklaptudirm raklaptudirm merged commit 61c9e8b into TheAlgorithms:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Code quality improvement

3 participants

@itsAkshayDubey @appgurueu @raklaptudirm