Skip to content

algorithm: mobius function implementation #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 6, 2022
Merged

algorithm: mobius function implementation #1088

merged 7 commits into from
Sep 6, 2022

Conversation

@itsAkshayDubey
Copy link
Contributor

@itsAkshayDubey itsAkshayDubey commented Sep 3, 2022 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

#1086

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
raklaptudirm
raklaptudirm previously approved these changes Sep 5, 2022
View reviewed changes
@appgurueu appgurueu added the algorithm Adds or improves an algorithm label Sep 5, 2022
appgurueu
appgurueu reviewed Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you drag PrimeFactors(number) out of the expression and assign it to a variable? Also, I'd prefer it if 'Number must be greater than zero' was an error rather than a return value.
@raklaptudirm raklaptudirm changed the title Add mobius function implementation algorithm: mobius function implementation Sep 6, 2022
@raklaptudirm raklaptudirm merged commit 6f55ed4 into TheAlgorithms:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

algorithm Adds or improves an algorithm

3 participants

@itsAkshayDubey @appgurueu @raklaptudirm