4. Median of Two Sorted Arrays #11
Conversation
| class Solution { | ||
| public double findMedianSortedArrays(int[] nums1, int[] nums2) { | ||
| double median = 0.0; | ||
| int n1 = nums1.length; |
There was a problem hiding this comment.
Please change the code to this:
int m = nums1.length;in order to keep consistent with the problem description. Also, change in other places where you've used n1.
| public double findMedianSortedArrays(int[] nums1, int[] nums2) { | ||
| double median = 0.0; | ||
| int n1 = nums1.length; | ||
| int n2 = nums2.length; |
There was a problem hiding this comment.
Please change the code to this:
int n = nums2.length;in order to keep consistent with the problem description. Also, change in other places where you've used n2.
| double median = 0.0; | ||
| int n1 = nums1.length; | ||
| int n2 = nums2.length; | ||
| int arr[] = new int[n1 + n2]; |
There was a problem hiding this comment.
Please provide a meaningful name to arr, for example: combined, and change in other places where you've used arr.
| int n2 = nums2.length; | ||
| int arr[] = new int[n1 + n2]; | ||
| int i = 0, j = 0; | ||
| int k = 0; |
There was a problem hiding this comment.
Please combine the above 2 lines to this:
int i = 0, j = 0, k = 0;| int arr[] = new int[n1 + n2]; | ||
| int i = 0, j = 0; | ||
| int k = 0; | ||
| while (i < n1 && j < n2) { |
There was a problem hiding this comment.
Keep a blank line before while. Try to always separate code blocks with a blank line so, please change in other places where appropriate.
| Great work! 🔥 Thank you so much for your contribution! 😀 |
2 participants
I have added a solution to this problem.