Hotfix: Submit button onClick and props #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| | ||
| export type SubmitProps = BaseFormButtonProps; | ||
| export interface SubmitProps extends BaseFormButtonProps, HTMLElementProps<HTMLButtonElement> { | ||
| fieldIds?: string[]; |
| "yargs": "^8.0.2" | ||
| }, | ||
| "dependencies": { | ||
| "@microsoft/ts-command-line": "^2.0.2", |
There was a problem hiding this comment.
Should be in devDependencies
| this.FormStore.InitiateFormSubmit(); | ||
| } | ||
| | ||
| if (this.props.onClick != null) { |
There was a problem hiding this comment.
Also, rename the function OnButtonClick to onClick. It's a bit more unified.
There was a problem hiding this comment.
Actually, in case it's protected, it should be named OnClick 👍
| @@ -0,0 +1,276 @@ | |||
| import * as path from "path"; | |||
There was a problem hiding this comment.
Why is the file name called rush-tools-new?
There was a problem hiding this comment.
Removed old rush-tools file and renamed rush-tools-new to rush-tools.
Fixed: 479b296
| } | ||
| } | ||
| | ||
| private consoleWrite(...text: string[]): void { |
There was a problem hiding this comment.
What?.. Why do you need this function?
There was a problem hiding this comment.
At first it was writing to console with a prefix, later on I removed it.
Fixed: 479b296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added missing HTMLProps in submit button
Implemented onClick in submit button
WIP Updated rush-tools