node 4.2.1: Don't manually define length of Buffers #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hello, could you give me a status on this? I'm more than happy to change anything if needed. Also note that the travis build only failed because of a timeout in the build, so it is passing if travis isn't slow. :) |
| @mikkeloscar sorry for the delay, the current version (where all manual length assignments were replaced with slices) passes all of the tests in node 0.8 through 5.0 and has been pushed as version 1.4.0 |
| Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It is undefined to define the length on an already allocated Buffer.
This removes any instances of that and makes sure to return a buffer of the expected length.
This also allows js-codepage to work with the latest version of node.
I know a few similar PR has been made, but this one aims to solve all of the related issues.