Updates to make smart-dispatch Python 3 compatible #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Author
| There are just a few issues on Travis, I'm going to check them out soon. |
MarcCote approved these changes Mar 15, 2017
| description='An easy to use job launcher for supercomputers with PBS compatible job manager.', | ||
| long_description=open('README.md').read(), | ||
| install_requires=['psutil>=1'], | ||
| install_requires=['psutil>=1', 'future'], |
Member
There was a problem hiding this comment.
Didn't know about that library. Neat!
| | ||
| try: | ||
| _unicode = unicode | ||
| _utf8 = lambda x: _unicode(x, 'UTF-8') |
Member
There was a problem hiding this comment.
I would have thought this sort of "hacks" isn't needed anymore thanks to the future library?
Author
There was a problem hiding this comment.
You're right. I did this before adding future as a dependency because I thought I could get around it without additional dependencies... until I got to the tests. I'll change it to use future.builtins.str instead.
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I made a few updates to make smart-dispatch compatible with Python 3, namely replacing all print statement calls by the print function, converting a bytestring to a string and using
openinstead offileto detect if the argument of the option-fis a file. I did not do extensive testing yet but this does not break it with Python 2 or 3 when running a basic test (smart_dispatch.py -qtest launch nvidia-smi).