RFC: Add statically checked macro for safe struct Peripherals creation #105
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
Peripherals::take()function has two disadvantages:This change uses the linker to statically ensure that only one Peripherals instance is constructed globally.
It introduces a new macro to avr_device that is used just like:
In case of multiple macro invocations, the linker will abort with
TODO:
DEVICE_PERIPHERALSaccess has to be removed from the generatedPeripherals::steal()function.Peripherals::take()function have to be removed from the generated code.