Skip to content

Conversation

@longye-tian
Copy link
Collaborator

@longye-tian longye-tian commented Jul 28, 2024

Dear John @jstac and Matt @mmcky ,

This pull request is to check the example admonition and spelling of from lecture [ar1_processes.md] to [eigen_II.md] according to #520 and #532.

The details are shown below:

  • ar1_processes.md
    • add two example admonitions
  • business_cycle.md (no typos, no example admonition)
  • cagan_adaptive.md (no typos, no example admonition)
  • cagan_ree.md
    • change 'a central banks's' to 'a central bank's'
    • change 'fisal' to 'fiscal'
    • change " to start a persistent inflation the government 'beings' " to 'begins'
  • cobweb.md (no typos, no example admonition)
  • commod_price.md (no typos, no example admonition)
  • complex_and_trig.md
    • add one example admonition
  • cons_smooth.md
    • change 'consumption smoothing model' to 'consumption-smoothing model' for consistency
    • change 'first order' to 'first-order' for consistency
    • change 'finanical' to 'financial'
    • change 'accross' to 'across'
    • change 'enlighening' to 'enlightening'
    • change the Capitalized title to match the style guide
    • change 'create a function that generate' to 'create a function that generates'
  • eigen_I.md
    • add one example admonition
  • eigen_II.md
    • change the subtitle to lower case to match the style guide
    • change 'Perron-Frobenius Theorem' to 'Perron-Frobenius theorem' for consistency (used in the current subtitles and also in wikipedia)
    • add example admonition
  • heavy_tails.md
    • change 'from world population review' to 'from the World Population Review'
    • change 'Law of Large Numbers' to 'law of large numbers' to match with Wikipedia form as discussed before
    • change 'heavy tailed' to 'heavy-tailed' for consistency
    • change 'The value the tail index' to 'The value of the tail index'
    • change 'Here is code that generates' to 'Here is the code generates'
    • add two example admonitions
  • inequality.md
    • change 'per capital' to 'per capita'
    • change 'others is zero' to 'others are zero'
    • change 'the world bank' to 'the World Bank' to match Wikipedia
    • add empty link to match with the style guide
    • change 'Western economies GDP' to 'Western economies'GDP'
    • add one example admonition
  • input_output.md
    • change 'input output' to 'input-output' for consistency
    • change feasible allocations must satisfy to feasible allocations must satisfy to match with style guide
    • change 'a two good economy' to 'a two-good economy'
    • add two example admonitions containing code blocks.

Best ❤️
Longye

update_ar1_example; no spelling error.
This commit updates cagan_ree.md typos
add example admonition
@netlify
Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 596bfec
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66ac218d4551310008200e8f
😎 Deploy Preview https://deploy-preview-538--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 28, 2024

@github-actions github-actions bot temporarily deployed to pull request July 28, 2024 13:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 28, 2024 13:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 28, 2024 14:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 28, 2024 14:03 Inactive
update typos
add example admonition
@github-actions github-actions bot temporarily deployed to pull request July 28, 2024 14:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 28, 2024 14:25 Inactive
add example admonition
@github-actions github-actions bot temporarily deployed to pull request July 28, 2024 14:33 Inactive
@longye-tian longye-tian changed the title Example and spelling [ar1_processes] to [eigen_II.md] Example and spelling Jul 28, 2024
@longye-tian longye-tian self-assigned this Jul 28, 2024
@github-actions github-actions bot temporarily deployed to pull request July 28, 2024 14:35 Inactive
@longye-tian longye-tian marked this pull request as ready for review July 28, 2024 14:35
@longye-tian longye-tian requested a review from mmcky July 28, 2024 14:35
@jstac
Copy link
Contributor

jstac commented Jul 29, 2024

Many thanks @longye-tian . This is very helpful.

@mmcky , please review and merge when ready.

 - change 'from world population review' to 'from the World Population Review' - change 'Law of Large Numbers' to 'law of large numbers' to match with Wikipedia form as discussed before - change 'heavy tailed' to 'heavy-tailed' for consistency - change 'The value the tail index' to 'The value of the tail index' - change 'Here is code that generates' to 'Here is the code generates'
@longye-tian longye-tian changed the title [ar1_processes] to [eigen_II.md] Example and spelling [ar1_processes] to [eigen_II] [heavy_tails]Example and spelling Aug 1, 2024
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:41 Inactive
 - change 'per capital' to 'per capita' - change 'others is zero' to 'others are zero' - change 'the world bank' to 'the World Bank' to match Wikipedia - add empty link to match with the style guide - change 'Western economies GDP' to 'Western economies'GDP'
@longye-tian longye-tian changed the title [ar1_processes] to [eigen_II] [heavy_tails]Example and spelling [ar1_processes] to [eigen_II] [heavy_tails][inequality]Example and spelling Aug 1, 2024
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:57 Inactive
 - change 'input output' to 'input-output' for consistency - change **feasible allocations must satisfy** to *feasible allocations must satisfy* to match with style guide - change 'a two good economy' to 'a two-good economy'
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 11:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 11:07 Inactive
longye-tian and others added 3 commits August 1, 2024 21:07
This example admonition include code block
cannot include code blocks in the example admonition
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 11:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 11:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 00:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 00:08 Inactive
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @longye-tian this is great work.

@mmcky mmcky merged commit 2ecd0ff into main Aug 2, 2024
@mmcky mmcky deleted the example_spelling branch August 2, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants