Skip to content

Conversation

@BruceCodesGithub
Copy link
Contributor

No description provided.

@BruceCodesGithub
Copy link
Contributor Author

@VincentRPS @Dorukyum please tell me if it needs any changes

Copy link
Contributor

@VincentRPS VincentRPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only thing i would change is the inconsistent usage of single quotes vs double quotes

@Dorukyum
Copy link
Member

Dorukyum commented Feb 2, 2022

Seems very good although maybe you could use timeout somewhere else, like a moderation category.

BruceCodesGithub and others added 2 commits February 2, 2022 17:19
maybe in the future we could resort to other things else than just making a toctree of every guide.
@BruceCodesGithub
Copy link
Contributor Author

lgtm, only thing i would change is the inconsistent usage of single quotes vs double quotes

Done

@VincentRPS VincentRPS merged commit b8cc77e into master Feb 2, 2022
@BruceCodesGithub
Copy link
Contributor Author

Seems very good although maybe you could use timeout somewhere else, like a moderation category.

I do not understand this, could you elaborate?

@BruceCodesGithub BruceCodesGithub deleted the bruce-pull-1 branch February 2, 2022 11:58
@VincentRPS
Copy link
Contributor

@BruceCodesGithub i think he means the timeout param which disables the button after sometime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants