#556 Fallback to alternate mtime correctly #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This will check the `stat` and `details` namespaces before defaulting to the current time.
james-emerton changed the title 
| Hi James, sorry for the delay in answering, my real-life job has been taking a lot of my time away 😓 A test would be very appreciated, as to avoid any regression (in case the code is changed or refactored, it would be better not to have this issue pop up again later). For this you can probably subclass |
lurch reviewed Dec 2, 2022
lurch reviewed Dec 2, 2022
| @althonos I've added a test for the fallback mtime behaviour, and I think this should now be ready for another look. |
lurch reviewed Dec 9, 2022
lurch reviewed Dec 9, 2022
lurch reviewed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
This addresses an issues where
write_zip()assumed that thedetailsnamespace was always available. Thestatnamespace will be checked first, followed bydetails, and finally the current time will be used ifst_mtimeis stillNone.I'm willing to author a test against this, but I'm only aware of this being an issue with the s3 filesystem (and only when it encounters a directory) and I'm not certain how best to test that here.
#556