Skip to content

Conversation

@Jonathans575
Copy link
Collaborator

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder pip install pre-commit && pre-commit install # Process previous code files separately pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

PR changes

Description

@paddle-bot
Copy link

paddle-bot bot commented Oct 28, 2025

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 12.12121% with 116 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@a83a474). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/datasets/finetuning.py 13.13% 86 Missing ⚠️
paddleformers/cli/train/sft/workflow.py 0.00% 26 Missing ⚠️
paddleformers/cli/hparams/data_args.py 0.00% 2 Missing ⚠️
paddleformers/cli/train/tuner.py 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (12.12%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@ Coverage Diff @@ ## develop #2803 +/- ## ========================================== Coverage ? 29.22% ========================================== Files ? 335 Lines ? 56399 Branches ? 0 ========================================== Hits ? 16483 Misses ? 39916 Partials ? 0 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Copy link
Collaborator

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonathans575 Jonathans575 merged commit f359de0 into PaddlePaddle:develop Oct 30, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants