Skip to content

Conversation

@Srijancse-zz
Copy link
Member

@tapasweni-pathak @nikhita Have a look, and let me know if this is fine.

Added Contributing to WikiToLearn guidelines!
Added details on how to contribute to WikiToLearn.
Copy link
Contributor

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome - even I might contribute after reading this. 😄
Minor comments, then LGTM.

`realpath` is in `AUR`

#### Docker installation
Docker is a quickly evolving technology, and it may be possible that the your distro official repository do not have yet the docker version requierd to run WTL. We thus recommend to install docker following the [official guide](https://docs.docker.com/engine/installation/).
Copy link
Contributor

@nikhita nikhita Jun 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your distro's official repository does not have the yet docker version required to run WTL yet.

#### Docker installation
Docker is a quickly evolving technology, and it may be possible that the your distro official repository do not have yet the docker version requierd to run WTL. We thus recommend to install docker following the [official guide](https://docs.docker.com/engine/installation/).

Do not forget to add your user to the docker group, so that you do not have to use super user privileges every time you have to manage docker images and volumes. WTLH is intended to work only if your user is added to docker group, otherwise you get errors related to missing the correct permissions since WTLH is not intended to be executed with super user rights.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I started out, I didn't know how to do this. Maybe add a link for clueless folks like me? 😛
This is the link: https://docs.docker.com/engine/installation/linux/linux-postinstall/


#### Requirements
* 64-Bit Computer (docker need a 64 bit system)
* GNU/Linux with docker or Windows/OSX with virtualization compatability and enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/compatability/compatibility


#### GNU/Linux installation
##### Prerequisites
WTL and WTLH have some dependecies:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/dependecies/dependencies


`./instance.sh delete`

Read the guide to [instance.sh](http://meta.wikitolearn.org/WikiToLearn_Home/WikitoLearn_Home_Documentation/Instance_Doc) for a deatailed description of how to use WTLH to manage the WTL instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/deatailed/detailed


#### Vagrant Installation for Windows/OSX

WTL is build to work on GNU/Linux. It uses GNU/Linux software, enclosed inside docker containers, that require the GNU/Linux kernel. Hence, if you want to develop WTL from a Windows/OSX environment you need to install a virtual linux system. We remind yout in order do use a virtualization software, you have to enable virtalization in your BIOS, as [explained in this page](http://meta.wikitolearn.org/WikiToLearn_Home/WikitoLearn_Home_Documentation/Local_WikiToLearn_Instance/How_To_Enable_Virtualization_On_Your_PC).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We remind you that

@nikhita
Copy link
Contributor

nikhita commented Jun 20, 2017

Just one more thing - can you add a note about what languages/technologies one should know before contributing? :)

@tapaswenipathak
Copy link
Member

After @nikhita's suggested changes, perfect for me too. :)

@nikhita
Copy link
Contributor

nikhita commented Aug 18, 2017

@srijancse no hurries, but a friendly ping :)

@nikhita nikhita self-assigned this Aug 18, 2017
@Srijancse-zz
Copy link
Member Author

Thanks @nikhita for reminding. Would fix it by weekend. ;)

Fixed typos, and updated links!
Copy link
Contributor

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more minor comments. :)

After the comments are addressed and all commits squashed to a single commit, this LGTM.

#### Docker installation
Docker is a quickly evolving technology, and it may be possible that the your distro's official repository does not have the docker version required to run WTL yet. We thus recommend to install docker following the [official guide](https://docs.docker.com/engine/installation/).

Do not forget to add your user to the docker group, so that you do not have to use super user privileges every time you have to manage docker images and volumes. WTLH is intended to work only if your user is added to docker group, otherwise you get errors related to missing the correct permissions since WTLH is not intended to be executed with super user rights. We recommend following this [guide] (https://docs.docker.com/engine/installation/linux/linux-postinstall/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the space between [guide] and (link). It does not render the markdown correctly.

WTL is build to work on GNU/Linux. It uses GNU/Linux software, enclosed inside docker containers, that require the GNU/Linux kernel. Hence, if you want to develop WTL from a Windows/OSX environment you need to install a virtual linux system. We remind you that in order do use a virtualization software, you have to enable virtalization in your BIOS, as [explained in this page](http://meta.wikitolearn.org/WikiToLearn_Home/WikitoLearn_Home_Documentation/Local_WikiToLearn_Instance/How_To_Enable_Virtualization_On_Your_PC).

##### Vagrant Installation
Using Vagrant is a quite simple way of using a virtual linux system for development purposes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is quite a simple way


This procedure requires using port 8080 tcp, 3128 tcp, 2121 to 2221 tcp on your host, this shouldn't be a problem unless you are running a network server (apache2, remote web control, ecc.).

If you have a **Windows/OSX** operating system, then you need to run a WikiToLearn instance using Vagrant. You can also install Vagrant if you have a Linux o.s. However, it is not required to get a fully working installation. You can just skip to the next step.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux OS instead of Linux o.s.


First, you need to install:

* [VirtualBox](https://www.virtualbox.org/wiki/Downloads/) as engine for vagrant
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: period at end of the sentence.

First, you need to install:

* [VirtualBox](https://www.virtualbox.org/wiki/Downloads/) as engine for vagrant
* [Vagrant](https://www.vagrantup.com/docs/installation/) for Windows/OS X users, for Linux it's optional. On Windows require restart.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, it requires a restart. (is this what you were trying to convey?)


#### Vagrant Installation for Windows/OSX

WTL is build to work on GNU/Linux. It uses GNU/Linux software, enclosed inside docker containers, that require the GNU/Linux kernel. Hence, if you want to develop WTL from a Windows/OSX environment you need to install a virtual linux system. We remind you that in order do use a virtualization software, you have to enable virtalization in your BIOS, as [explained in this page](http://meta.wikitolearn.org/WikiToLearn_Home/WikitoLearn_Home_Documentation/Local_WikiToLearn_Instance/How_To_Enable_Virtualization_On_Your_PC).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/virtalization/virtualization





Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra newlines

@nikhita
Copy link
Contributor

nikhita commented Sep 9, 2017

Oh, also noticed this has conflicts with README.md. You probably need to do a rebase too.

@nikhita
Copy link
Contributor

nikhita commented Sep 20, 2017

bump ^^

@tapaswenipathak tapaswenipathak merged commit 5abcf88 into OpenSourceHelpCommunity:master Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants