Skip to content

Conversation

McMlok
Copy link
Contributor

@McMlok McMlok commented Oct 13, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit 
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

I add HTTP Client name to prevent duplicit client registration if final application reference two or more generated APIs which contains API with same name. HTTP Client registration use only type name not full name including namespace. This fixes #22082

@mandrean, @shibayan, @Blackclaws, @lucamazzanti, @iBicha

@devhl-labs
Copy link
Contributor

Interesting change. I think its ok as long as the checks pass.

@McMlok
Copy link
Contributor Author

McMlok commented Oct 15, 2025

Sorry for dumb question. Is there anything I have to do? Github Action pass on last commit, first has a problem with wrong white spaces and samples. And all CircleCI runs also pass. Did I miss something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants