Skip to content

Conversation

Nounoursdestavernes
Copy link
Contributor

Hello there,

This is my PR for the french translation. (#129)

Let me know if you want any changes.
Best regards,
NounoursDesTavernes / Aurélien TRONCY.

@Nounoursdestavernes Nounoursdestavernes changed the base branch from master to develop April 4, 2024 08:17
Copy link
Contributor

@llegaz llegaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass on my review for this french translation.

@llegaz
Copy link
Contributor

llegaz commented Apr 5, 2024

I will try to finish my review as soon as possible.

@Nounoursdestavernes Good work btw and thank you for your contribution.

@Nounoursdestavernes
Copy link
Contributor Author

Nounoursdestavernes commented Apr 5, 2024

Thx for the review @llegaz I made the modifications :)

It's my first contribution to an Open Source project and first translation it was not as easy as I thought so I thank you a lot for your help ;)

I will be happy to continue to improve the quality of the translation if you have any changes to suggest

@Nounoursdestavernes
Copy link
Contributor Author

Hi everyone,
I hope you're doing well.

Do you have any update about my last commentaries @llegaz ?

I was wondering if you had the time to consider them.

Copy link
Contributor

@llegaz llegaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finished to review this translation for the 2023 edition.

Except for the few suggestions everything is good to go on my side :)

@PauloASilva
Copy link
Collaborator

Hi @Nounoursdestavernes
Can you please confirm whether all changes were applied and this is the final version?

I'll need a few days to work on this to make sure everything works as expected after merging.

Nounoursdestavernes and others added 9 commits April 24, 2024 19:51
 Correction of some translation mistake Co-authored-by: Laurent Legaz <laurent@legaz.eu>
Co-authored-by: Laurent Legaz <laurent@legaz.eu>
Co-authored-by: Laurent Legaz <laurent@legaz.eu>
Co-authored-by: Laurent Legaz <laurent@legaz.eu>
Co-authored-by: Laurent Legaz <laurent@legaz.eu>
Co-authored-by: Laurent Legaz <laurent@legaz.eu>
Co-authored-by: Laurent Legaz <laurent@legaz.eu>
Co-authored-by: Laurent Legaz <laurent@legaz.eu>
Co-authored-by: Laurent Legaz <laurent@legaz.eu>
@Nounoursdestavernes
Copy link
Contributor Author

Hi @PauloASilva
Yes everything is good and this is the final version !

Thanks a lot @llegaz for your review :)

@llegaz
Copy link
Contributor

llegaz commented Apr 27, 2024

You are very welcome @Nounoursdestavernes thanks again for your work.

@Nounoursdestavernes
Copy link
Contributor Author

Hi there,

Is everything okay ? Should I make any changes to the PR ? @PauloASilva

Best regards,
NounoursDesTavernes / Aurélien TRONCY.

@PauloASilva
Copy link
Collaborator

Is everything okay ? Should I make any changes to the PR ? @PauloASilva

I didn't find the time yet to review the PR (make sure everything works properly).
I should be able to do it soon.

@PauloASilva PauloASilva merged commit 1724508 into OWASP:develop Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants