Skip to content

Conversation

faizzaidi
Copy link
Contributor

Hi @PauloASilva,

I am raising PR for Bahasa (Indonesian) translation.
#66

Kindly, let me know if any changes are needed.

Thanks,
Faiz

@PauloASilva PauloASilva changed the base branch from master to develop October 16, 2023 08:44
@PauloASilva
Copy link
Collaborator

Hey,
I would love to make the API Security Top 10 available in your language, but we need to find someone to help reviewing your translation here on GitHub.

Anyone you may know of that can help here?

Cheers,
Paulo A. Silva

@PauloASilva
Copy link
Collaborator

In fact it seems that @tedher already did it 🤔

There's this last comment from @tedher: @faizzaidi do you plan to address it?

@PauloASilva PauloASilva self-requested a review June 3, 2024 14:12
@faizzaidi
Copy link
Contributor Author

Hi @PauloASilva ,

Yes, I have reviewed and merged the changes from @tedher.

@faizzaidi faizzaidi closed this Jun 3, 2024
@PauloASilva PauloASilva reopened this Jun 3, 2024
@PauloASilva
Copy link
Collaborator

Alright, so it is ready for merge, right?

@faizzaidi
Copy link
Contributor Author

yes

@PauloASilva
Copy link
Collaborator

Hi @faizzaidi,
There are some fixes required in order to properly build Bahasa translation.

Please review the links in the following files which in general point to a non-existing file whose name ends with -id.md:

  • editions/2019/ba/0x02-foreword.md
  • editions/2019/ba/0x03-introduction.md
  • editions/2019/ba/0x04-release-notes.md
  • editions/2019/ba/0xd0-about-data.md
  • editions/2023/ba/0x00-toc.md
  • editions/2023/ba/0x02-foreword.md
  • editions/2023/ba/0xa1-broken-object-level-authorization.md

Cheers,
Paulo A. Silva

@PauloASilva
Copy link
Collaborator

I also need your help to translate a few Mkdocs Material template keywords into Bahasa.

  1. Create a new file ba.html at docs/overrides/partials/languages
  2. Copy this into the new ba.html file you've created (there's an Indonesian version available)
  3. Translate the values
  4. Commit the changes

Thanks,
Paulo A. Silva

@faizzaidi
Copy link
Contributor Author

Hi @PauloASilva ,

Sure, I will update it and let you know.

@PauloASilva
Copy link
Collaborator

PauloASilva commented Jun 16, 2024

Hi folks,
Please check these changes, reviewing your translation to understand whether they apply. Nested lists should use 4 spaces indentation.

Cheers,
Paulo A. Silva

@faizzaidi
Copy link
Contributor Author

Hi @PauloASilva,

I have added the changes and fixed the redirection issues.
Please let me know if anything else needs to be done.

Thanks,
Faiz

@PauloASilva PauloASilva merged commit a7b3525 into OWASP:develop Aug 31, 2024
@PauloASilva
Copy link
Collaborator

Hi Folks,
Sorry about the delay to get this merged but additional changes were required.

Both translations (2019 and 2023) were released in v2.5.0 and are now live: 2019 and 2023.

Cheers,
Paulo A. Silva

@tedher
Copy link
Contributor

tedher commented Aug 31, 2024 via email

@PauloASilva
Copy link
Collaborator

Hi @tedher
Not sure what does "different with the rest" means: the image in your comment is missing.

Anyway, the way to go is Pull Request: would you like to open it?

Cheers,
Paulo A. Silva

@faizzaidi
Copy link
Contributor Author

Hi @PauloASilva ,

I will check the issue and update this issue soon.

Thanks,
Faiz

@faizzaidi
Copy link
Contributor Author

Hi @PauloASilva,

Here is the pull request with the fix for this issue:

#135

Feel free to let me know if you need anything else.

Thanks,
Faiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment