Skip to content
This repository was archived by the owner on May 25, 2020. It is now read-only.

React hot loader v4 #209

Open
Suraj-Chandola wants to merge 4 commits into
base: master
Choose a base branch
from
Open

React hot loader v4 #209

Suraj-Chandola wants to merge 4 commits into from

Conversation

@Suraj-Chandola
Copy link

@Suraj-Chandola Suraj-Chandola commented Nov 20, 2018 •
edited
Loading

resolve #208
@coveralls
Copy link

coveralls commented Nov 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 77.524% when pulling 6c1ef9f on Suraj-Chandola:react-hot-loader-v4 into 95e67da on ModusCreateOrg:master.
@grgur
Copy link
Member

grgur commented Nov 21, 2018

Thank you so much for working on this @Suraj-Chandola

I checked it out, but I'm not sure I see RHL working well. Changes keep on reloading the browser

animation

Could you take a look please? Also, it's ok if you want to upgrade with RHL 4.5.1+
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Nov 22, 2018

Code Climate has analyzed commit 6c1ef9f and detected 0 issues on this pull request.

View more on Code Climate.
@Suraj-Chandola
Copy link
Author

Suraj-Chandola commented Nov 22, 2018

@grgur Fixed and updated to 4.5.1
@grgur
Copy link
Member

grgur commented Nov 26, 2018

Thanks for updating! I still see a refresh when changing code, no matter where. Can you replicate that? I tried adding random text to App/index.js and Budget/index.js and it reloaded on both occasions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@Suraj-Chandola @coveralls @grgur