-
- Notifications
You must be signed in to change notification settings - Fork 3
Refine onboarding flow with data consent and completion screens #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MihaiCristianCondrea merged 10 commits into main from codex/design-professional-onboarding-experience Sep 12, 2025
Merged
Changes from 1 commit
Commits
Show all changes
10 commits Select commit Hold shift + click to select a range
1a4ae7a Improve onboarding with data consent and completion screens
MihaiCristianCondrea c685368 Refine theme selection UI and add tools namespace
MihaiCristianCondrea ef214f2 Add default tab selection screen
MihaiCristianCondrea ac4d673 Refine onboarding layouts and update links
MihaiCristianCondrea e9a578d Refine onboarding selection layout and enable data binding
MihaiCristianCondrea 31c0d53 Add icons for data consent screen
MihaiCristianCondrea d7b6a47 Polish onboarding UI and consent handling
MihaiCristianCondrea e9a128e Improve onboarding typography and theme selection
MihaiCristianCondrea 8c9fda9 Refine onboarding theme handling and integrate consent
MihaiCristianCondrea 1309583 Refactor and update UI elements
MihaiCristianCondrea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Improve onboarding with data consent and completion screens
- Loading branch information
commit 1a4ae7a0ac2e8d575443f22b3c30e97ae099df7d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions 31 app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/onboarding/DoneFragment.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package com.d4rk.androidtutorials.java.ui.screens.onboarding; | ||
| | ||
| import android.os.Bundle; | ||
| import android.view.LayoutInflater; | ||
| import android.view.View; | ||
| import android.view.ViewGroup; | ||
| | ||
| import androidx.annotation.NonNull; | ||
| import androidx.annotation.Nullable; | ||
| import androidx.fragment.app.Fragment; | ||
| | ||
| import com.d4rk.androidtutorials.java.databinding.FragmentOnboardingDoneBinding; | ||
| | ||
| public class DoneFragment extends Fragment { | ||
| | ||
| private FragmentOnboardingDoneBinding binding; | ||
| | ||
| @Nullable | ||
| @Override | ||
| public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, | ||
| @Nullable Bundle savedInstanceState) { | ||
| binding = FragmentOnboardingDoneBinding.inflate(inflater, container, false); | ||
| return binding.getRoot(); | ||
| } | ||
| | ||
| @Override | ||
| public void onDestroyView() { | ||
| super.onDestroyView(); | ||
| binding = null; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent"> | ||
| | ||
| <LinearLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:orientation="vertical" | ||
| android:padding="24dp"> | ||
| | ||
| <com.google.android.material.card.MaterialCardView | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:padding="24dp" | ||
| app:cardElevation="0dp"> | ||
| | ||
| <LinearLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:gravity="center" | ||
| android:orientation="vertical"> | ||
| | ||
| <ImageView | ||
| android:layout_width="64dp" | ||
| android:layout_height="64dp" | ||
| android:layout_marginBottom="16dp" | ||
| android:src="@drawable/ic_check_circle" /> | ||
| | ||
| <com.google.android.material.textview.MaterialTextView | ||
| style="@style/TextAppearance.Material3.TitleLarge" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginBottom="8dp" | ||
| android:text="@string/onboarding_done_title" /> | ||
| | ||
| <com.google.android.material.textview.MaterialTextView | ||
| style="@style/TextAppearance.Material3.BodyMedium" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:gravity="center" | ||
| android:text="@string/onboarding_done_subtitle" /> | ||
| | ||
| </LinearLayout> | ||
| </com.google.android.material.card.MaterialCardView> | ||
| </LinearLayout> | ||
| </ScrollView> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Crashlytics consent toggle never disables collection
The new data-consent screen stores the user’s choice in shared preferences (
setCrashlyticsEnabled), but the value is never applied to the Crashlytics SDK. There is no code anywhere in the app that readskey_firebase_crashlyticsor callsFirebaseCrashlytics.getInstance().setCrashlyticsCollectionEnabled(...), so crash reports remain enabled by default regardless of the user’s selection. This presents a privacy/compliance risk because the UI promises a choice that isn’t honored. Consider applying the stored value during app startup and updating the SDK configuration whenever the setting changes.Useful? React with 👍 / 👎.