Skip to content

Fix crash on unsuccessful network request in UseCase4 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix crash on unsuccessful network request in UseCase4 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...secasesonandroid/usecases/coroutines/usecase4/VariableAmountOfNetworkRequestsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class VariableAmountOfNetworkRequestsViewModel(
val recentVersions = mockApi.getRecentAndroidVersions()
val versionFeatures = recentVersions
.map { androidVersion ->
async { mockApi.getAndroidVersionFeatures(androidVersion.apiLevel) }
viewModelScope.async { mockApi.getAndroidVersionFeatures(androidVersion.apiLevel) }
}.awaitAll()
uiState.value = UiState.Success(versionFeatures)
} catch (exception: Exception) {
Expand Down
6 changes: 3 additions & 3 deletions ...sesonandroid/usecases/coroutines/usecase4/VariableAmountOfNetworkRequestsViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class VariableAmountOfNetworkRequestsViewModelTest {
}

@Test
fun `performNetworkRequestsConcurrently() should return Error UiState on successful network requests after 2000ms`() =
fun `performNetworkRequestsConcurrently() should return Success UiState on successful network requests after 2000ms`() =
mainCoroutineScopeRule.runBlockingTest {
val responseDelay = 1000L
val fakeApi = FakeSuccessApi(responseDelay)
Expand Down Expand Up @@ -147,7 +147,7 @@ class VariableAmountOfNetworkRequestsViewModelTest {

Assert.assertTrue(receivedUiStates.isEmpty())

viewModel.performNetworkRequestsSequentially()
viewModel.performNetworkRequestsConcurrently()

advanceUntilIdle()

Expand All @@ -170,7 +170,7 @@ class VariableAmountOfNetworkRequestsViewModelTest {

Assert.assertTrue(receivedUiStates.isEmpty())

viewModel.performNetworkRequestsSequentially()
viewModel.performNetworkRequestsConcurrently()

advanceUntilIdle()

Expand Down