Topic/fix sca #195
Open
Topic/fix sca #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
line 133: Function 'lcurl_easy_cleanup_storage' should have return at the end of each execution path rule-id: CERT_C-MSC37-a-2
message: Non-initialized "ptr" is passed to "lua_pushlstring" as const When input length is zero the transformation loop does not run, leaving buffer contents uninitialized. Although lua_pushlstring with length 0 would not read from ptr, some static analyzers flag this as use of uninitialized data. Init buffer to empty string to silence warnings (CERT_C-EXP33-a-1).
hunter-79 force-pushed the topic/fix_sca branch from 571b0b3 to e3ed642 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix issues found by Parasoft C/C++test (static code analysis) usind SEI CERT coding standard as rule set.