Skip to content

Adding partial catalan translation #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

Adding partial catalan translation #817

merged 1 commit into from
Oct 3, 2024

Conversation

@francescroycampderros
Copy link

@francescroycampderros francescroycampderros commented Sep 17, 2024

Adding partial Catalan translation. Creating a new 'ca' folder inside 'resources/lang' with its 'messages.php' file.
@JulianPrieber
Copy link
Member

JulianPrieber commented Sep 18, 2024

Thank you for contributing @francescroycampderros!

What does "partial" mean here? Are some keys missing? What's the status here?
@francescroycampderros
Copy link
Author

francescroycampderros commented Sep 18, 2024

Sorry by "partial" I meant incomplete, I will need some more days to finish it.
@JulianPrieber
Copy link
Member

JulianPrieber commented Sep 18, 2024

Alright 👍
@JulianPrieber JulianPrieber added enhancement New feature or request needs more work labels Sep 18, 2024
@JulianPrieber JulianPrieber self-requested a review September 18, 2024 10:21
JulianPrieber
JulianPrieber requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@JulianPrieber JulianPrieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish translation
@lastsamurai26 lastsamurai26 merged commit ffbeaad into LinkStackOrg:main Oct 3, 2024
@JulianPrieber
Copy link
Member

JulianPrieber commented Oct 3, 2024

Huh?
@JulianPrieber
Copy link
Member

JulianPrieber commented Oct 3, 2024

Did we just merge this?
@lastsamurai26
Copy link
Member

lastsamurai26 commented Oct 3, 2024

Why not ?
Or we will create a repos with languages ?
@JulianPrieber
Copy link
Member

JulianPrieber commented Oct 3, 2024

Maybe I missed something, but we had this pull request on revision due to it not being finished.
Are we managing this language on the Discord?
@lastsamurai26
Copy link
Member

lastsamurai26 commented Oct 3, 2024

Maybe I missed something, but we had this pull request on revision due to it not being finished. Are we managing this language on the Discord?

It may have happened, but I'm not sure if we should integrate them all but possibly as a separate repo. So that we only have German English and then in a separate repo the languages ?
@JulianPrieber
Copy link
Member

JulianPrieber commented Oct 7, 2024

A separate repo might actually be better. I think we should switch to that for v5.
@JulianPrieber
Copy link
Member

JulianPrieber commented Oct 7, 2024

I'll revert the changes, we'll include Catalan once the translation is finished.
@JulianPrieber JulianPrieber mentioned this pull request Oct 7, 2024
Merged
@JulianPrieber
Copy link
Member

JulianPrieber commented Oct 7, 2024

@francescroycampderros Please open another pull request once you finish the translation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs more work

3 participants

@francescroycampderros @JulianPrieber @lastsamurai26