Skip to content

Conversation

@raon0211
Copy link

@raon0211 raon0211 commented Sep 18, 2020

Dependencies should be specified in either dependencies or peerDependencies section of package.json when accessed in production code via import statements or requires. It seems that although rxjs-hooks is importing react and rxjs in its production code, neither of them is specified.

Below is a part of the production bundle where rxjs and react is imported. (dist/esm/use-event-callback.js)

image

This makes the library to break in environments using strict dependency management systems such as yarn v2.

This pull request fixes the issue by specifying react and rxjs in peerDependencies of package.json.

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #402 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 51 51 Branches 6 6 ========================================= Hits 51 51 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ab3ea...9dc42c3. Read the comment docs.

@Miloas
Copy link
Contributor

Miloas commented Mar 26, 2021

hi, very thanks for your contribution, we have landed it in master.

@Miloas Miloas closed this Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants