Feature Discussion: Make rsa optional #459
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This PR should serve as the basis of a discussion since I am not sure myself if it is a good idea or not. But maybe a few words on how I got here. I am currently using this crate in one of my projects and I really like it so far. However the audit tools complain about this vulnerability (RUSTSEC-2023-0071).
I am not 100% sure if this vulnerability affects the
jsonwebtokencrate or not and its also not that important since I am using no RSA functionality.This brought me to the code and it looked like all the
rsaparts can be made optional and it is still a very useful crate.To not break everything for everyone it should remain a
defaultfeature for now so users of this library would not have a breaking change, but people who want to skiprsacan do so.Questions for Discussion
aws_lc_rs?