Skip to content

Conversation

@kstiehl
Copy link

@kstiehl kstiehl commented Nov 9, 2025

Description

This PR should serve as the basis of a discussion since I am not sure myself if it is a good idea or not. But maybe a few words on how I got here. I am currently using this crate in one of my projects and I really like it so far. However the audit tools complain about this vulnerability (RUSTSEC-2023-0071).
I am not 100% sure if this vulnerability affects the jsonwebtoken crate or not and its also not that important since I am using no RSA functionality.

This brought me to the code and it looked like all the rsa parts can be made optional and it is still a very useful crate.
To not break everything for everyone it should remain a default feature for now so users of this library would not have a breaking change, but people who want to skip rsa can do so.

Questions for Discussion

  1. Does this approach make sense for the project?
  2. Should we also make RSA optional when using aws_lc_rs?
  3. Are there any concerns about feature flag complexity?
@Keats
Copy link
Owner

Keats commented Nov 9, 2025

  1. Not really I think? You have the choice of multiple backends and people can just deny that warning if they want to use rust-crypto and don't use RSA
  2. No reason to
  3. Yeah, it's a feature flag for a feature flag
@kstiehl kstiehl closed this Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants