Support multiple algorithms when decoding #433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the signature verification logic and adds a new test to ensure proper handling of multiple algorithms during token decoding.
To be clear: If the purpose is to ensure that a single validator always has to have the same family of algorithms, then this PR is invalid. :)
Improvements to signature verification logic:
src/decoding.rs: Simplified thevalidate_signatureblock by replacing the loop with a more conciseanyiterator to check if the key's family matches any of the allowed algorithms. This resolves a bug where the validation would fail if the family of the first entry in the supported algorithms array mismatches with the key, even if another algorithm would match.Expanded test coverage:
tests/hmac.rs: Added a new test,decode_token_multiple_algorithms, to verify that decoding works correctly when multiple algorithms are specified in the validation object. This ensures compatibility with tokens signed using different algorithms.