add pkg-config definitions #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hi @guijan did you performed tests on CMake build sytems after the change? Thanks! |
| No, I only tried Meson. And good call, because it was broken. I'll work on it more. |
eli-schwartz suggested changes May 29, 2022
guijan force-pushed the add-pkgconfig branch 2 times, most recently from c9c4917 to 55a6ba9 Compare eli-schwartz suggested changes May 30, 2022
pkg-config makes curlcpp easy to use with non-CMake build systems like the .cmake files make it easy to use with CMake. Done with a lot of help from @eli-schwartz.
| The initial version must have been the worst PR I have ever sent, but now I think it's in good shape. I wrote a test project that depends on curlcpp with CMake, Meson, and POSIX Make build definitions: https://github.com/guijan/curlcpp-pc-test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
pkg-config makes curlcpp easy to use with non-CMake build systems like the .cmake files make it easy to use with CMake.
I've tested this on OpenBSD.