Skip to content

Conversation

@Xeverous
Copy link
Contributor

  • bumped required CMake version
  • removed globbing
  • added targets with appropriate PUBLIC/PRIVATE properties
  • added an option to use pkg-config
  • added link-time optimization for release builds
  • added default build type
  • added some warnings and rewritten other compiler flags to use
    modern CMake functions
  • installed headers are in extra directory to avoid polluting global
    include directory
  • removed bii directory
- bumped required CMake version - removed globbing - added targets with appropriate PUBLIC/PRIVATE properties - added an option to use pkg-config - added link-time optimization for release builds - added default build type - added some warnings and rewritten other compiler flags to use modern CMake functions - installed headers are in extra directory to avoid polluting global include directory - removed bii directory
@Xeverous Xeverous mentioned this pull request Feb 25, 2020
@Xeverous
Copy link
Contributor Author

Apart from CMake version bump, the only breaking change is the new directory for includes. Includes like <file> are heavily discouraged and any library that installs itself in the root of include path risks overwriting other such libraries. The preferred way is <libname/file> (at least until C++20 modules).

@JosephP91 JosephP91 merged commit 5ac4d86 into JosephP91:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants