Skip to content

Conversation

DevinTDHa
Copy link
Member

Description

This PR adds a flag to remove thinking tags (<think>...</think>) in AutoGGUFModel responses. Users can use setRemoveThinkingTag(tag: String) to set a tag to be removed. The matching regex corresponds to (?s)<$tag>.+?</$tag>.

Motivation and Context

How Has This Been Tested?

new tests passing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@DevinTDHa DevinTDHa changed the base branch from master to release/620-release-candidate October 20, 2025 11:02
@DevinTDHa DevinTDHa force-pushed the feature/SPARKNLP-1283-autogguf-thinking-flag branch from 6a6a8f4 to acbf7ab Compare October 20, 2025 12:08
@DevinTDHa DevinTDHa marked this pull request as ready for review October 20, 2025 12:09
@DevinTDHa DevinTDHa merged commit f49cc87 into JohnSnowLabs:release/620-release-candidate Oct 20, 2025
4 checks passed
@DevinTDHa DevinTDHa mentioned this pull request Oct 20, 2025
10 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18651497810

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.094%

Totals Coverage Status
Change from base Build 18649965549: 0.0%
Covered Lines: 11833
Relevant Lines: 21478

💛 - Coveralls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants