Bugfix: menuShouldBlockScroll now applies the correct right-padding #6004
+5 −10
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Bug Description
When
menuShouldBlockScroll=true, the right padding for thebodytag is computed. This is to account for the right scrollbar disappearing when this prop is set. However, it computes this new right padding by accounting for any right padding applied through thestylesprop; this doesn't take into account for right padding added from classes.Bug Example
An example of the bug can be seen here where a class based right padding is applied using tailwind:
https://codesandbox.io/p/devbox/react-select-v5-sandbox-forked-fckm5s
Opening and closing the select will cause a shift in padding due to incomplete padding extraction.
Solution
https://codesandbox.io/p/devbox/react-select-v5-sandbox-forked-qnd3sz?workspaceId=ws_CRHnC6VmWcMy6krqXNjCPZ
window.getComputedStyleis used to get the final computed right padding which accounts for padding from a class or style.paddingRightproperty fromSTYLE_KEYSas we are no longer using this style anywhere in the code.Closes
#5342