Optimise dotnet build time #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Sweet! Sorry, juusst seeing this. Will test :-) |
| Hey @JSv4 let's drop this - we've noticed sporadic build failures that seem to be caused by a race condition. I haven't had time to properly debug, but for now we're pointing back to the repo here and accepting the higher build times. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When building the package, we can publish dotnet artefacts in parallel procs, and we can run IO-bound compression in parallel threads. This provides roughly a 30-35 second decrease in execution time on my new MBP.
Before:
python build_differ.py 41.88s user 1.93s system 101% cpu 43.191 total
Now:
python build_differ.py 53.09s user 3.63s system 484% cpu 11.706 total