Fix Javadoc deployment #29
Conversation
| | ||
| script: | ||
| - mvn clean package | ||
| - mvn javadoc:javadoc |
There was a problem hiding this comment.
This additional command should work fine, but I think if you had changed the package goal in the first command to be install that it would also create the javadocs (I think... it might also require an additional pom.xml config change as well, not 100% sure)). Just for future reference :)
Edit: Actually, I just reminded myself that the original mvn clean package command already creates the javadocs as that is one of the jars that are deployed to the git repo's Release tab. Do we still need an additional mvn command to do that again?
There was a problem hiding this comment.
Oh, probably not then 😕 I wasn't sure originally if that was the issue we were having.
| - provider: script | ||
| script: "./build/push-javadoc-to-gh-pages.sh" | ||
| skip_cleanup: true | ||
| on: |
There was a problem hiding this comment.
Hmmm, I don't think we want to deploy on all builds, do we? That's why I had set the on: tags qualifier.
Edit: never mind, I now see that this change was only done to the new javadoc deploy step :)
There was a problem hiding this comment.
The script was designed to deploy branches too
See: http://watson-developer-cloud.github.io/java-sdk/
Users can see what's in master or any other branch
This PR fixes my last one to make sure generating the Javadoc and pushing them to the
gh-pagesbranch actually works. The changes I had to make were:mvn javadoc:javadoccommand to actually generate the docsgenerate-index-htmlscript