Skip to content

fix: Allow IAM client_id/secret to be supplied for basicauth header #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2019
Merged

fix: Allow IAM client_id/secret to be supplied for basicauth header #25

merged 2 commits into from
Apr 16, 2019

Conversation

@padamstx
Copy link
Contributor

@padamstx padamstx commented Apr 16, 2019

@padamstx padamstx self-assigned this Apr 16, 2019
@padamstx padamstx requested a review from lpatino10 April 16, 2019 16:02
@padamstx padamstx added the ready-for-review PR is ready for a review label Apr 16, 2019
lpatino10
lpatino10 approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@lpatino10 lpatino10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌
@padamstx padamstx merged commit 59bb5cf into master Apr 16, 2019
@padamstx padamstx mentioned this pull request Apr 17, 2019
Closed
@padamstx padamstx deleted the issue-851 branch June 16, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review PR is ready for a review

3 participants

@padamstx @lpatino10