feat: improve behavior of HTTP redirects #218
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
padamstx commented Nov 27, 2023
padamstx commented Nov 27, 2023
padamstx force-pushed the custom-redirects branch 4 times, most recently from 82a2ac6 to 4f20699 Compare 
| Put this back into draft status until we get an approval from CISO. |
pyrooka approved these changes Nov 29, 2023
src/main/java/com/ibm/cloud/sdk/core/http/RedirectInterceptor.java Outdated Show resolved Hide resolved
src/main/java/com/ibm/cloud/sdk/core/http/RedirectInterceptor.java Outdated Show resolved Hide resolved
src/main/java/com/ibm/cloud/sdk/core/http/RedirectInterceptor.java Outdated Show resolved Hide resolved
Comment on lines 121 to 122
| entry("Cookie", "chocolate chip"), | ||
| entry("Cookie2", "snickerdoodle"), |
This commit introduces a new okhttp interceptor that will implement customized behavior for HTTP redirects. Specifically, "safe" headers will be included in a redirected request if the original and redirected hosts are the same, or are both within IBM's "cloud.ibm.com" domain. Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
padamstx force-pushed the custom-redirects branch from 4f20699 to cec19ce Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This commit introduces a new okhttp interceptor that will implement customized behavior for HTTP redirects.
Specifically, "safe" headers will be included in a redirected request if the original and redirected hosts are the same, or are both within IBM's "cloud.ibm.com" domain.