WIP: Fix test failures that occur with "nondex" plugin #159
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes several flaky tests:
equals()compares twoHashMap<String, T> dynamicPropertiesinDynamicModel.In this PR,
LinkedHashMapis used instead ofHashMapto resolve the ordering issue. This solution considers 2DynamicModels are same if their elements have the same insertion order. However, theequals()function should be modified to completely resolve the ordering issue.In this PR,
JSONAssertlibrary is used to ignore the order difference when comparing 2 JSON strings.In this PR, the comparations are changed to match the style of other tests in the same files while ignoring the ordering issue.