Skip to content

feat(VpcInstanceAuthenticator): add support for new VPC authentication flow #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 8, 2021
Merged

feat(VpcInstanceAuthenticator): add support for new VPC authentication flow #153

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aa24a0c
feat(VpcInstanceAuthenticator): add support for new VPC authenticatio…
padamstx Oct 5, 2021
8388f0d
fix: refactor authenticator to use base class
padamstx Oct 18, 2021
18e858b
fix: rename getImdsEndpoint -> getImsEndpoint
padamstx Oct 21, 2021
f91e184
docs: add clarification about IAM token service endpoint
padamstx Oct 22, 2021
629564b
fix: use correct property names in validation error message
padamstx Oct 25, 2021
7911eb1
chore: update .secrets.baseline
padamstx Oct 25, 2021
4ce3416
Merge remote-tracking branch 'origin/main' into vpc-authenticator
padamstx Nov 5, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use correct property names in validation error message
  • Loading branch information
@padamstx
padamstx committed Oct 25, 2021
commit 629564bb0e7ea84e719b4da7a63e391ced5736e3
2 changes: 1 addition & 1 deletion src/main/java/com/ibm/cloud/sdk/core/security/VpcInstanceAuthenticator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public void validate() {
// At most one of iamProfileCrn or iamProfileId may be specified.
if (StringUtils.isNotEmpty(getIamProfileCrn()) && StringUtils.isNotEmpty(getIamProfileId())) {
throw new IllegalArgumentException(
String.format(ERRORMSG_ATMOST_ONE_PROP_ERROR, "iamProfileName", "iamProfileId"));
String.format(ERRORMSG_ATMOST_ONE_PROP_ERROR, "iamProfileCrn", "iamProfileId"));
}
}

Expand Down