feat(BaseService): remove final modifier from createServiceCall #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove the `final` modifier from the BaseService#createServiceCall to allow extending services to override.
ricellis force-pushed the createservicecall-override-2739 branch from cd8766d to 21049d9 Compare 
padamstx approved these changes Jul 12, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Jul 12, 2021
# [9.11.0](9.10.4...9.11.0) (2021-07-12) ### Features * **BaseService:** remove final modifier from createServiceCall ([#132](#132)) ([2e35d1f](2e35d1f))
| 🎉 This PR is included in version 9.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove the
finalmodifier from theBaseService#createServiceCallto allow extending services to override.This provides a hook point that can be used to modify every request earlier than an interceptor is able to do so.
Added a test that will fail to compile if the final modifier is re-added inadvertently. The assertion itself is slightly pointless as it effectively validates the JVM's override functionality, but it seems nicer than having a "compile-only" test.
Note also as per JLS 13.4.17 is a binary compatible change.