Skip to content

Conversation

@padamstx
Copy link
Contributor

@padamstx padamstx commented Apr 1, 2021

Updates the guava dependency to avoid vulnerabilities, plus a few other deps.
Oh, and I also fixed a few javadoc warnings.

@padamstx padamstx requested a review from mkistler April 1, 2021 19:02
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a reformat on this file... there is really only 1 small change which was needed when upgrading to the latest checkstyle.


/**
* Returns the value of query parameter `param` from urlStr, or null when not found.
* @param urlStr the URL string containing the query param to retrieve
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow, these javadoc warnings previously evaded our intricate testing framework LOL

Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@padamstx padamstx merged commit 775a4d9 into main Apr 1, 2021
@padamstx padamstx deleted the update-deps branch April 1, 2021 23:12
@ibm-devx-automation
Copy link

🎉 This PR is included in version 9.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants