Skip to content

Conversation

@padamstx
Copy link
Contributor

@padamstx padamstx commented Mar 1, 2021

This PR updates the IAM live server test to fix the comments that described the required config properties, plus it adds a test that verifies that a refresh token can be obtained using the authenticator.

@padamstx padamstx requested review from dpopp07 and rmkeezer March 1, 2021 19:53
@padamstx
Copy link
Contributor Author

padamstx commented Mar 1, 2021

@dpopp07 @rmkeezer Dustin, Matthew... I added you both as reviewers so you're aware of the IAM live server test that's part of the Java core. Perhaps we could add something similar for Node and Python.

Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Copy link
Contributor

@rmkeezer rmkeezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@padamstx padamstx merged commit a98703c into main Mar 4, 2021
@padamstx padamstx deleted the update-iam-test branch March 4, 2021 20:19
@ibm-devx-automation
Copy link

🎉 This PR is included in version 9.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants