Skip to content

Video #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2019
Merged

Video #6

merged 3 commits into from
Jul 22, 2019

Conversation

@sanjeevghimire
Copy link
Contributor

*video added.
Sanjeev Ghimire added 2 commits July 22, 2019 09:16
markstur
markstur reviewed Jul 22, 2019
View reviewed changes
Copy link

@markstur markstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. One little logging thing.
Also was wondering why diff showed hole file. CR change?
server.js Outdated
app.post('/newDataEntry', function(request, response){
console.log('NEW DATA API CALL:');
console.log(request);
console.log('NEW DATA API CALL:');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why still log this if not logging any details?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its just a INFO log. We can remove it actually.
markstur
markstur approved these changes Jul 22, 2019
View reviewed changes
Copy link

@markstur markstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@markstur markstur merged commit 212de72 into master Jul 22, 2019
@markstur markstur deleted the video branch July 22, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@sanjeevghimire @markstur