Skip to content

Conversation

@wilybrace
Copy link
Contributor

The introduction of a second, similarly named implicit rule left
the "warning suppression" rule as the more explicit rule.
(PR #1137)
This had the negative effect of suppressing the binary builds.

This change reverts the removal of the explicit build rules,
leaving the implicit rule to only cover invocations of build-*
for unneeded binaries

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
The introduction of a second, similarly named implicit rule left the "warning suppression" rule as the more explicit rule. This had the negative effect of suppressing the binary builds. This change reverts the removal of the explicit build rules, leaving the implicit rule to only cover invocations of build-* for unneeded binaries
@jkatz jkatz merged commit 64b3f5e into CrunchyData:master Dec 16, 2019
@wilybrace wilybrace deleted the bugfix_double_wildcard branch December 16, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants