Various fixes: #43
Merged
Various fixes: #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1. We do need lexical scopes - so the idea that we could just create unique names for all vars doesn't work because then it means that all vars are available in scopes where they are not supposed to be, leading to creation of phi's that reference undefined vars. 2. The type conversion from EeZee to SON Types had many bugs. 3. The definition of ARY in TypeStruct meant that int[] ended up with incorrect aliases. Additional fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We do need lexical scopes - so the idea that we could just create unique names for all vars doesn't work because then it means that all vars are available in scopes where they are not supposed to be, leading to creation of phi's that reference undefined vars.
The type conversion from EeZee to SON Types had many bugs.
The definition of ARY in TypeStruct meant that int[] ended up with incorrect aliases.